feat: electra process_operations changes #1426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in with at validate_attestation
rodrigo-o
reviewed
Apr 23, 2025
Collaborator
rodrigo-o
left a comment
rodrigo-o
left a comment
There was a problem hiding this comment.
Already reviewed constants, accessors and mutators and they look great, still going through operations
rodrigo-o
reviewed
Apr 23, 2025
Collaborator
rodrigo-o
left a comment
rodrigo-o
left a comment
There was a problem hiding this comment.
Half-way in operations, left a couple of comments
Co-authored-by: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
…rawal_request Co-authored-by: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
rodrigo-o
reviewed
Apr 23, 2025
Collaborator
rodrigo-o
left a comment
rodrigo-o
left a comment
There was a problem hiding this comment.
Great work, left some final comments!
…artial_withdrawal_on_full_queue?
…lid_withdrawal_request
rodrigo-o
approved these changes
Apr 24, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
Co-authored-by: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
Co-authored-by: Rodrigo Oliveri <rodrigooliveri10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement the changes made to
process_operationby modifying existing for_ops and adding the newprocess_withdrawal_requestandprocess_consolidation_request.process_deposit_requestwas done in #1424Description
process_attestationlinkget_pending_balance_to_withdrawlinkprocess_voluntary_exitlinkprocess_withdrawal_requestlinkqueue_excess_active_balancelinkswitch_to_compounding_validatorlinkget_consolidation_churn_limitlinkprocess_consolidation_requestlinkcompute_consolidation_epoch_and_update_churnlinkFixed Spec Tests
Spec Test Progress
11370 tests, 108 failures, 784 skipped